From 94ef967bda2607c05d1d83da3324c3cbd364070d Mon Sep 17 00:00:00 2001
From: evanwill <evanpeterw@gmail.com>
Date: Thu, 22 Sep 2016 21:46:11 -0700
Subject: [PATCH] accessibility fixes. Add label to search box and navigation
arrows.
---
_includes/episode_navbar.html | 9 ++++-----
_includes/navbar.html | 2 +-
2 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/_includes/episode_navbar.html b/_includes/episode_navbar.html
index 082047f..a789d3d 100644
--- a/_includes/episode_navbar.html
+++ b/_includes/episode_navbar.html
@@ -1,6 +1,5 @@
{% comment %}
Find previous and next episodes (if any).
- Including file must pass episode_navbar_title=true or ...=false to display episode title.
{% endcomment %}
{% for episode in site.episodes %}
{% if episode.url == page.url %}
@@ -21,9 +20,9 @@
<div class="col-md-1">
<h3>
{% if prev_episode %}
- <a href="{{ page.root }}{{ prev_episode.url }}"><span class="glyphicon glyphicon-menu-left"></span></a>
+ <a href="{{ page.root }}{{ prev_episode.url }}"><span class="glyphicon glyphicon-menu-left" aria-hidden="true"></span><span class="sr-only">previous episode</span></a>
{% else %}
- <a href="{{ page.root }}/"><span class="glyphicon glyphicon-menu-up"></span></a>
+ <a href="{{ page.root }}/"><span class="glyphicon glyphicon-menu-up" aria-hidden="true"></span><span class="sr-only">lesson home</span></a>
{% endif %}
</h3>
</div>
@@ -36,9 +35,9 @@
<div class="col-md-1">
<h3>
{% if next_episode %}
- <a href="{{ page.root }}{{ next_episode.url }}"><span class="glyphicon glyphicon-menu-right"></span></a>
+ <a href="{{ page.root }}{{ next_episode.url }}"><span class="glyphicon glyphicon-menu-right" aria-hidden="true"></span><span class="sr-only">next episode</span></a>
{% else %}
- <a href="{{ page.root }}/"><span class="glyphicon glyphicon-menu-up"></span></a>
+ <a href="{{ page.root }}/"><span class="glyphicon glyphicon-menu-up" aria-hidden="true"></span><span class="sr-only">lesson home</span></a>
{% endif %}
</h3>
</div>
diff --git a/_includes/navbar.html b/_includes/navbar.html
index 126fe3d..b0a2c3d 100644
--- a/_includes/navbar.html
+++ b/_includes/navbar.html
@@ -68,7 +68,7 @@
</ul>
<form class="navbar-form navbar-right" role="search" id="search" onsubmit="google_search(); return false;">
<div class="form-group">
- <input type="text" id="google-search" placeholder="Search...">
+ <input type="text" id="google-search" placeholder="Search..." aria-label="Google site search">
</div>
</form>
</div>
--
GitLab